data-apis / array-api

RFC document, tooling and other content related to the array API standard
https://data-apis.github.io/array-api/latest/
MIT License
204 stars 42 forks source link

feat: add `max rank` to inspection API capabilities #763

Closed kgryte closed 2 months ago

kgryte commented 3 months ago

This PR

asmeurer commented 3 months ago

New APIs shouldn't be backported. Only things like typo fixes and clarifications that don't affect implementations should be backported to previous versions.

kgryte commented 2 months ago

As this PR has received 2 approvals and no objections, I'll go ahead and merge. Any further changes can be addressed in follow-up PRs. Thanks all!

asmeurer commented 1 month ago

Since this isn't yet in a released version of the standard, I would like to propose that we rename "max rank" to something like "max dimensions". The term "rank" is ambiguous when referring to an array, since it can also refer to the linear algebra definition of rank (or even the tensor definition, which is yet another thing). I know we also use the term "rank" throughout the standard, but I would also propose that we replace this with something like "dimensionality".

rgommers commented 1 month ago

I think that's a fair comment. "max ndim" would be another option if name length matters.

rgommers commented 1 month ago

Briefly discussed today: seemed fine to everyone to change name - @asmeurer will open a new PR.

asmeurer commented 1 month ago

809