data-apis / dataframe-api

RFC document, tooling and other content related to the dataframe API standard
https://data-apis.org/dataframe-api/draft/index.html
MIT License
102 stars 20 forks source link

add Column.len, which returns Scalar, instead of Column.__len__ (returning int) #331

Closed MarcoGorelli closed 11 months ago

kkraus14 commented 12 months ago

@shwina what is your thoughts on this one? I know cuDF is eager and so it always has the length of columns accessible, but given its scalar class is built to be on device (ignoring the internal implementation of how it handles both host and device access), do you have any thoughts here?

shwina commented 12 months ago

So I expect the length to be used for things like comparisons or equality checking which does work between Scalars and plain Python integers in cuDF. This should be an OK change

MarcoGorelli commented 11 months ago

approved in today's call