search

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
220 stars 77 forks source link

More robust handling of exceptions inside share manager ECS task #1266

Open SofiaSazonova opened 1 month ago

SofiaSazonova commented 1 month ago

Right now if an exception is raised inside approve_share of revoke_share job the status of the share will be stuck in "in_progress" state. What do we need to do:

  1. Move share object status update to "finally" job
  2. In case dataset_lock is failed to be released, we need to think about expiry mechanism
  3. Dataset_lock can be a piece of information we may want to show in UI
dlpzx commented 1 month ago

Hi @SofiaSazonova I am working on the share managers a lot in https://github.com/data-dot-all/dataall/issues/1283. This could be a part X in the list of items to improve the sharing. I have added it to the list of todos

TejasRGitHub commented 1 month ago

Along with the share manager, please check out this issue to add robust handling in ECS task for share verifier - https://github.com/data-dot-all/dataall/issues/1300