No effect on session after setting cognito_user_session_timeout_inmins

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.

https://data-dot-all.github.io/dataall/

Apache License 2.0

228 stars 82 forks source link

No effect on session after setting cognito_user_session_timeout_inmins #1296

Closed shivalkarrahul closed 3 months ago

shivalkarrahul commented 3 months ago

Describe the bug

Hello Team,

We are using v2.2.0 and have set cognito_user_session_timeout_inmins to 60. As per the doc - cognito_user_session_timeout_inmins -> The number of minutes to set the refresh token validity time for user session’s in Cognito before a user must re-login to the data.all UI (default: 43200 - i.e. 30 days) Doc Link: https://data-dot-all.github.io/dataall/deploy-aws/

However, we still see that the session still remains active and the user is not asked to re-login.

How to Reproduce

edit cdk.json
set "cognito_user_session_timeout_inmins": 60 in DeploymentEnvironments section

Expected behavior

The user must be asked to re-login after 60 minutes.

Your project

No response

Screenshots

No response

OS

Python version

AWS data.all version

2.2.0

Additional context

No response

SofiaSazonova commented 3 months ago

Hi @shivalkarrahul ! Thanks for opening issue! Can you confirm, that both Access token expiration and ID token expiration values in AWS Cognito are set less than 60 mins? We will test this behaviour and will be back with more detailed answer.

SofiaSazonova commented 3 months ago

I couldn't reproduce the bug, so please, provide more details about your deployment.

shivalkarrahul commented 3 months ago

Hello @SofiaSazonova ,

Thanx for your reply. Here is what we have in Incognito. Refresh token expiration is still 30 days.

SofiaSazonova commented 3 months ago

Oh, I see. The problem is not, that timeout doesn't work, but it's not set right!

SofiaSazonova commented 3 months ago

@shivalkarrahul Could you please confirm, that after you commit and push this changes of cdk.json into CodePipelines, the pipeline was build without any errors?

shivalkarrahul commented 3 months ago

Hello @SofiaSazonova , Yes, I confirm that the pipeline completed successfully.

anmolsgandhi commented 3 months ago

Hi @shivalkarrahul , is this issue resolved ? if so can we close this issue?

anmolsgandhi commented 3 months ago

Closing this issue as it seems to be resolved now, feel free to reopen if you have questions or still need any help on this issue.