Integration tests executed on a real deployment as part of the CICD - Shares

[dlpzx]

Same as for https://github.com/data-dot-all/dataall/issues/1220.

This issue is to track the progress for the Shares modules. It has its own dedicated issue because of the challenge of validating the shares

[dlpzx]

Required tests for basic coverage

For fresh deployments

For each of the following API calls we need to test authorized and unauthorized scenarios as well as all possible configurations (e.g. autoapproval...)

• [x] Add items to request
• [x] Reject request
• [x] Approve request*
  • [x] Folder sharing validation
  • [x] Bucket sharing validation
  • [x] Table sharing validation
• [x] Create Share request
• [x] Revoke items*
  • [x] Folder sharing validation
  • [x] Bucket sharing validation
  • [x] Table sharing validation
• [x] Delete share *if times allows implement team roles as well as consumption roles. If it is not possible implement consumption roles and leave team roles as next steps

  For backwards compatibility

  For updated Dataset stacks with existing shares validate:

  • [ ] Folder sharing validation
  • [ ] Bucket sharing validation
  • [ ] Table sharing validation

Full coverage [WIP]

For fresh deployments

• [x] Edit share request purpose
• [ ] Email notifications
• [x] Auto-approval datasets

For backwards compatibility

For updated Dataset stacks:

• [ ] Approve request
  • [ ] Folder sharing validation
  • [ ] Bucket sharing validation
  • [ ] Table sharing validation
• [ ] Revoke items
  • [ ] Folder sharing validation
  • [ ] Bucket sharing validation
  • [ ] Table sharing validation

[SofiaSazonova]

Current progress Happy path

[SofiaSazonova]

Happy path tests:

New Shares:

• [x] Create Share request
• [x] Submit request without Items (not allowed)
• [x] Add items to request
• [x] Submit request without autoapproval (status -- Submitted)
• [x] Change request purpose
• [x] Submit request with autoapproval (status -- Approved)
• [x] Reject request
• [x] Change reject purpose
• [x] Approve request
• [x] Request succeeded
• [x] Item health verification
• [x] Folder sharing validation (cal list objects via s3 accesspoint , for same account check write|modify)
• [x] Bucket sharing validation (cal list objects in s3 bucket , for same account check write|modify)
• [x] Table sharing validation (cal perform athena query: select * from db.table , for same account check write|modify)
• [x] Revoke items
• [x] Folder sharing validation (no more access)
• [x] Bucket sharing validation (no more access)
• [x] Table sharing validation (no more access)
• [x] Delete share
• [ ] Check, that resources, involved in shares, can not be deleted from data.all, while share is active.

Persistent Shares:

• [x] Update persistent envs and datasets used for shares (made in fixtures)
• [x] Share verification test
• [x] Check item access test
• [x] Revoke share test
• [x] Check no access left
• [x] Add all items back to share
• [x] Share approved/processed successfully
• [x] Share verification test
• [x] Check item access test (no more access)

[SofiaSazonova]

Share 'breaks' tests:

1. S3 bucket policy is manually changed 1.a. Permissions are insufficient 1.b. More permissions are granted
2. IAM role policy is manually changed 1.a. Permissions are insufficient 1.b. More permissions are granted

• [ ] Share verification job finished
• [ ] Items are Unhealthy, the Reason is relevant
• [ ] Share reapplied successfully
• [ ] Access to folders/bucket/tables is restored
• [ ] For same account shares: separate checks for Read/Write/Modify

[SofiaSazonova]

Resource are missing test:

1. Share principal IAM role is deleted
2. S3 bucket/ AccessPoint/Folder/Table/DB is deleted

• [ ] Share verification job finished
• [ ] Items are Unhealthy, the Reason is relevant
• [ ] Unhealthy Items can be revoked
• [ ] Share can be deleted

[SofiaSazonova]

User Managed policy test: Share principal - consumption role without data.all managed policies

• [ ] Share can not be created, if required policies are not attached and the flag "attach missing policies" is False
• [ ] Share can be created, when the policies are attached
• [ ] Share is created and policies are attached, when required policies are not attached and the flag "attach missing policies" is True