search

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
235 stars 82 forks source link

cw_canaries stack fails due to unsupported CloudWatch synthetics version #1446

Open jpdev42 opened 3 months ago

jpdev42 commented 3 months ago

Describe the bug

Refer to line 84 of deploy/stacks/cw_canaries.py here.

According to Runtime versions using Python and Selenium Webdriver, the runtime version syn-python-selenium-1.0 is no longer supported.

When the nested stack is created, the following error occurs: 

Resource handler returned message: "Invalid request provided: Deprecated runtime version specified. (Service: Synthetics, Status Code: 400, Request ID: 2615cc97-59ab-42f1-b0df-4db59ce5ece6)" (RequestToken: 9b8c547f-26ec-45b2-423c-c19c883e5aba, HandlerErrorCode: InvalidRequest)

How to Reproduce

Include the configuration parameters to activate canaries in cdk.json:

    ...
    "enable_cw_canaries": true
    ...

Then, deploy dataall.

Expected behavior

The deployment should complete without error.

Your project

No response

Screenshots

No response

OS

Mac

Python version

3.12.2

AWS data.all version

2.6.0

Additional context

No response

noah-paige commented 3 months ago

Hi @jpdev42 - thank you for bringing this issue to our attention. We will look into the above and see if any blockers to upgrading the runtime version to the latest (or non-deprecated)

Will do some exploration on the above but please do let us know if you were able to find a workaround for the above issue as well

jpdev42 commented 3 months ago

Hi @noah-paige ,

I was able to fix this issue by changing the synthetics version that was hardcoded here. But perhaps it would be better to pull this value from some configuration - e.g. cdk.json.

Thanks!