search

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
235 stars 82 forks source link

Warn users when they approve share requests with Write/Modify permissions #1566

Open petrkalos opened 2 months ago

petrkalos commented 2 months ago

Currently the share view indicates the requested permissions but given that customers are used to Read-only nature of data.all it might be good to implement a warning mechanism to increase awareness.

My suggestions, first one is much simpler to implement but the second is more assertive.

  1. Only for Write/Modify share requests display a sizeable warning as a subheader in the ShareView image

  2. Only for Write/Modify share requests create a confirmation pop-up when clicking the Approve button image

dlpzx commented 2 months ago

I kind of like the second one better, but waiting to see what the rest think

anushka-singh commented 2 months ago

I like option 2 better!

zsaltys commented 2 months ago

I like option 2.. I prefer a user confirms explicitly they definitely want write permissions to be granted. Then there's no excuse 'I didn't see it'

TejasRGitHub commented 2 months ago

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

petrkalos commented 2 months ago

I like option 2 as well.

@petrkalos , would this dialog box show for all kind of approvals ( i.e. Read-Only, Write /Modify ) ?

No I am thinking only if it's not read-only

petrkalos commented 2 months ago

@zsaltys @TejasRGitHub as discussed see #1568