A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
This PR introduces MANAGE_SHARES permission to enable data.all admins the ability to enable/disable shares permissions at the application-level.
The new permission would get created in the savepermissions Lambda trigger; but by default the permissions would be disabled for all existing groups in the platform. This would cause breaking changes and admins would need to enable this permission manually for each group. To avoid this, this PR includes a migration script that creates the permission and attaches it to existing groups.
Testing
[x] Test migration script locally
[x] Test migration script in CICD
[x] Perform share mutations in real AWS deployment (approve share object, submit, add items) with tenant permissions
[x] Perform share mutations in real AWS deployment (approve share object, submit, add items) WITHOUT tenant permissions (See screenshot)
Relates
Security
Please answer the questions below briefly where applicable, or write N/A. Based on
OWASP 10.
Does this PR introduce or modify any input fields or queries - this includes
fetching data from storage outside the application (e.g. a database, an S3 bucket)?
Is the input sanitized?
What precautions are you taking before deserializing the data you consume?
Is injection prevented by parametrizing queries?
Have you ensured no eval or similar functions are used?
Does this PR introduce any functionality or component that requires authorization?
How have you ensured it respects the existing AuthN/AuthZ mechanisms?
Are you logging failed auth attempts?
Are you using or adding any cryptographic features?
Do you use a standard proven implementations?
Are the used keys controlled by the customer? Where are they stored?
Are you introducing any new policies/roles/users?
Have you used the least-privilege principle? How?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Feature or Bugfix
Detail
This PR introduces
MANAGE_SHARES
permission to enable data.all admins the ability to enable/disable shares permissions at the application-level.The new permission would get created in the savepermissions Lambda trigger; but by default the permissions would be disabled for all existing groups in the platform. This would cause breaking changes and admins would need to enable this permission manually for each group. To avoid this, this PR includes a migration script that creates the permission and attaches it to existing groups.
Testing
Relates
Security
Please answer the questions below briefly where applicable, or write
N/A
. Based on OWASP 10.eval
or similar functions are used?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.