data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
235 stars 82 forks source link

Add MANAGE_SHARES permissions #1702

Closed dlpzx closed 6 days ago

dlpzx commented 1 week ago

Feature or Bugfix

Detail

This PR introduces MANAGE_SHARES permission to enable data.all admins the ability to enable/disable shares permissions at the application-level.

The new permission would get created in the savepermissions Lambda trigger; but by default the permissions would be disabled for all existing groups in the platform. This would cause breaking changes and admins would need to enable this permission manually for each group. To avoid this, this PR includes a migration script that creates the permission and attaches it to existing groups.

Testing

image

Relates

Security

Please answer the questions below briefly where applicable, or write N/A. Based on OWASP 10.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.