search

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
229 stars 82 forks source link

If a dataset is not in CREATE_COMPLETE status, disable S3 Upload functionality #390

Open rbernotas opened 1 year ago

rbernotas commented 1 year ago

Is your idea related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently (v.1.4.3), if a user creates a new dataset, and the dataset is not yet in the CREATE_COMPLETE status, the user can still click into the dataset, go to the "Upload" tab, and try to upload and crawl the data that is uploaded. This will lead to errors and the table seems to never be correctly crawled.

Describe the solution you'd like A clear and concise description of what you want to happen.

Upload tab and/or the Upload functionality should be disabled or greyed-out to the user, if the dataset is not in the CREATE_COMPLETE state. Once the dataset has reached status CREATE_COMPLETE, the Upload functionality can be re-enabled for the user.

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

dlpzx commented 1 year ago

Hi @rbernotas, thanks for raising the issue! We'll pick it up as soon as possible or we can work together in developing it.

manjulaK commented 1 year ago

dear @dlpzx since could please consider pushing this as part of v1.6?

zsaltys commented 7 months ago

@dlpzx can we close this? I think this was merged?

anmolsgandhi commented 4 months ago

@noah-paige @dlpzx was this merged? can we close this then?

noah-paige commented 2 months ago

We have feature flags to enable / disable file upload altogether for a data.all deployment but if file upload actions are enabled we currently do not conditionally disable the upload feature until the dataset stack status is in a CREATE_COMPLETE or UPDATE_COMPLETE stage