search

data-dot-all / dataall

A modern data marketplace that makes collaboration among diverse users (like business, analysts and engineers) easier, increasing efficiency and agility in data projects on AWS.
https://data-dot-all.github.io/dataall/
Apache License 2.0
236 stars 82 forks source link

SageMaker domain #48

Closed dosiennik closed 2 years ago

dosiennik commented 2 years ago

Got a question about SageMaker domain, as far as I have noticed it needs to be setup manually as a prerequisite. Is there any reason for it or any plans to make it automatic?

JahedZ commented 2 years ago

Hi, although I don't have a release date to communicate yet, we do have CDK code to automatically provision a Sagemaker Domain upon creation of a data.all environment. In the meantime, you do have to setup the domain manually to leverage Sagemaker Studio features. (cc @dlpzx)

dosiennik commented 2 years ago

Hi. Thanks for the info. If you have any release date, please let me know.

dosiennik commented 2 years ago

Apart from that please let me know if there are any specific prerequisites/requirements for setting up a domain, like tag values etc?

dosiennik commented 2 years ago

@dlpzx thanks for adding it to the roadmap.

Do you have any release date in mind? Asking since this feature got quite important to us and currently we consider implementing it by ourselves vs waiting for it to be released - although here we are not sure how much effort it requires and when you are planning to release it.

Apart from that in case we will need to implement it by ourselves we need to know if there are any specific requirements for the domain - like tag values etc.

@JahedZ has mentioned that you have already had some code for it.

louishourcade commented 2 years ago

Is there someone actively working on this task now ? Otherwise I can take it

JahedZ commented 2 years ago

@louishourcade I was hoping to submit the Pull request next week. This includes Automatic creation of a Sagemaker domain upon creation of a data.all environment, using minimal settings with direct internet access (Depending on customers, they would need to customize their settings).

Once this is done, I would also like to modify the creation of Sagemaker user profiles. Following this blog post, we can make it so data.all users can access Sagemaker Jumpstarts and Sagemaker Projects

louishourcade commented 2 years ago

Alright thanks @JahedZ for the clarification. If you want, I have the code of a previous version of data.all in which we were creating SageMaker domains as part of the environment stack. If that could help, tell me and I'll send it to you.

dosiennik commented 2 years ago

@JahedZ hope you are fine :) sorry for disturbing you. Can I ask you about the plans/estimated date for creating a PR for this? Thanks in advance.

JahedZ commented 2 years ago

Hi @dosiennik, my apologies for the delay. I opened this PR https://github.com/awslabs/aws-dataall/pull/82 Hope this helps :)

github-actions[bot] commented 2 years ago

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see. If you need more assistance, please either tag a team member or open a new issue that references this one. If you wish to keep having a conversation with other community members under this issue feel free to do so.