Fix numeric validator - Githubissues

data-driven-forms / react-forms

React library for rendering forms.

https://data-driven-forms.org/

Apache License 2.0

303 stars 87 forks source link

Fix numeric validator #1382

Closed jspannu919 closed 1 year ago

jspannu919 commented 1 year ago

Currently the numeric validators (min or max) doesn't shows any validation error if the value in the field is zero.

Scenario: If a field is added with min validation with threshold as 3, the validator will show error for values like 1,2,-1 etc but nothing for 0.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-forms	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 26, 2023 7:35am

DataDrivenFormsBot commented 1 year ago

No new version will be released. Current: v3.20.8 [DataDrivenFormsBot]

codecov[bot] commented 1 year ago

Codecov Report

Merging #1382 (a69abb6) into master (7dedcb4) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         210      210           
  Lines        3647     3647           
  Branches     1271     1271           
=======================================
  Hits         3468     3468           
  Misses        179      179

Impacted Files	Coverage Δ
...orm-renderer/src/validators/validator-functions.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rvsia commented 1 year ago

:tada: This PR is included in version 3.20.9 :tada:

The release is available on

Data-Driven-Forms.org!