Closed jkozol closed 10 months ago
vercel[bot]
commented
10 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-forms | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Oct 23, 2023 2:33pm |
DataDrivenFormsBot
commented
10 months ago A new version (fix) will be released: v3.21.8 [DataDrivenFormsBot]
codecov[bot]
commented
10 months ago Merging #1416 (96c82c0) into master (baaf600) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## master #1416 +/- ##
=======================================
Coverage 94.96% 94.96%
=======================================
Files 210 210
Lines 3672 3672
Branches 1284 1284
=======================================
Hits 3487 3487
Misses 185 185 | Files | Coverage Δ | |
|---|---|---|
| ...-mapper/src/wizard/wizard-components/wizard-nav.js | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
rvsia
commented
10 months ago :tada: This PR is included in version 3.21.8 :tada:
The release is available on
In the Image Builder wizard we are no longer seeing step numbers with the pf5 upgrade.
The wizard navigation should only contain one WizardNav component. Wrapping the WizardNavItems in two WizardNav components is causing all steps to be treated as substeps and therefore don't have step numbers. The fix is to remove one of the WizardNav wrappers.
The other WizardNav component is here: https://github.com/data-driven-forms/react-forms/blob/baaf60020a972b51d01ef7722cb91ab66297dc98/packages/pf4-component-mapper/src/wizard/wizard.js#L129
And here is a screenshot of the issue.