fix(mui): Correctly use onBlur and onFocus for MUIDatePicker and MUITimePicker

data-driven-forms / react-forms

React library for rendering forms.

https://data-driven-forms.org/

Apache License 2.0

295 stars 85 forks source link

fix(mui): Correctly use onBlur and onFocus for MUIDatePicker and MUITimePicker #1419

Closed DNahr closed 10 months ago

DNahr commented 10 months ago

Description

onBlur and onFocus weren't called for MUIDatePicker and MUITimePicker. Can be tested in the mui playground. Required validation won't be displayed without these changes because meta.touched never gets set.

Schema (if applicable)

Checklist: (please see documentation page for more information)

[x] Yarn build passes
[x] Yarn lint passes
[x] Yarn test passes
[ ] Test coverage for new code (if applicable)
[ ] Documentation update (if applicable)
[x] Correct commit message
- format fix|feat({scope}): {description}
- i.e. fix(pf3): wizard correctly handles next button
- fix will release a new _._.X version
- feat will release a new _.X._ version (use when you introduce new features)
  - we want to avoid any breaking changes, please contact us, if there is no way how to avoid them
- scope: package
- if you update the documentation or tests, do not use this format
  - i.e. Fix button on documenation example page

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-forms	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 3, 2023 7:19pm

DataDrivenFormsBot commented 10 months ago

A new version (fix) will be released: v3.21.9 [DataDrivenFormsBot]

codecov[bot] commented 10 months ago

Codecov Report

Merging #1419 (c4c9222) into master (a1b587b) will not change coverage. Report is 1 commits behind head on master. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1419   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         210      210           
  Lines        3672     3672           
  Branches     1284     1284           
=======================================
  Hits         3487     3487           
  Misses        185      185

Files	Coverage Δ
...ui-component-mapper/src/date-picker/date-picker.js	`81.81% <ø> (ø)`
...ui-component-mapper/src/time-picker/time-picker.js	`81.81% <ø> (ø)`

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

rvsia commented 10 months ago

:tada: This PR is included in version 3.21.9 :tada:

The release is available on

Data-Driven-Forms.org!