data-driven-forms / react-forms

React library for rendering forms.
https://data-driven-forms.org/
Apache License 2.0
295 stars 85 forks source link

fix(pf4): fix date and time picker change attributes order #1436

Closed Hyperkid123 closed 8 months ago

Hyperkid123 commented 8 months ago

Fixes #1432

Description

Fix the order of the pickers attributes sent to the change callback

vercel[bot] commented 8 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 8:42am
codecov[bot] commented 8 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2dce5f0) 94.92% compared to head (c05811a) 94.88%. Report is 1 commits behind head on master.

Files Patch % Lines
...f4-component-mapper/src/date-picker/date-picker.js 66.66% 1 Missing :warning:
...f4-component-mapper/src/time-picker/time-picker.js 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1436 +/- ## ========================================== - Coverage 94.92% 94.88% -0.05% ========================================== Files 210 210 Lines 3706 3711 +5 Branches 1292 1295 +3 ========================================== + Hits 3518 3521 +3 - Misses 188 190 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rvsia commented 8 months ago

:tada: This PR is included in version 3.22.2 :tada:

The release is available on

Data-Driven-Forms.org!