Closed haydenlinder closed 5 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
react-forms | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 21, 2024 8:54am |
Attention: Patch coverage is 66.66667%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 94.48%. Comparing base (
271e466
) to head (8edbfea
).
Files | Patch % | Lines |
---|---|---|
packages/common/src/use-select/reducer.js | 66.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closing in favor of https://github.com/data-driven-forms/react-forms/pull/1449
Closing in favor of #1449
Ah. I see you found part of the problem as well. :)
Related to #1448
Description
When using searchable select with loadoOptions, the spinner persists after the promises have resolved.
The cause was this line returning true because there was an extra
compareValues
function in the reducer payloads.I saved that function to another variable and removed it from the payload.
Schema (if applicable)
Checklist: (please see documentation page for more information)
Yarn build
passesYarn lint
passesYarn test
passesfix|feat({scope}): {description}
fix(pf3): wizard correctly handles next button
Fix button on documenation example page