data-edu / dataedu

An R package associated with the Data Science in Education Using R book
https://data-edu.github.io/dataedu/
Creative Commons Attribution 4.0 International
74 stars 12 forks source link

Gill Sans not loading on Macs #82

Open ivelasq opened 4 years ago

ivelasq commented 4 years ago

Referencing post: https://github.com/data-edu/data-science-in-education/issues/519

Gill Sans MT is a font that is bundled only on some Macs, and {extrafont} doesn't necessarily load it unless it's already on the user's computer. To be able to use theme_dataedu(), some Mac users have to download Gill Sans MT, use extrafont::font_import(), then loadfonts(). Not sure if this is also the case with Windows users.

Need to decide how to fix this in the package, either by directing users to download the font, throwing an informative warning if the font is not installed on their computers and letting users render the plot with the default font, or changing Gill Sans to a font that doesn't have these issues.

jrosen48 commented 4 years ago

thx for cross-reffing this. Is there a good source for downloading Gill Sans MT? I'm having some difficulty but this may be to my "font newbie status" 😂

ivelasq commented 4 years ago

Try this site out!

restrellado commented 4 years ago

Oh I don't remember where I got it. But I followed Isabella's lead on this so it was probably the site she suggested

On Fri, May 15, 2020 at 6:43 AM Isabella Velásquez notifications@github.com wrote:

Try this site https://www.dafontfree.net/freefonts-gill-sans-mt-f64845.htm out!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/data-edu/dataedu/issues/82#issuecomment-629243494, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXLW3ML47K2TBHCHYMRUOLRRVBITANCNFSM4MEONKGQ .

jrosen48 commented 4 years ago

Do you have any thoughts on switching to another font (that is more likely to be installed) - or having something nifty like IF gill sans is not installed then use this font instead?

ivelasq commented 4 years ago

Hi @joshuarosenberg - I have used {emojifont} as an example and now Gill Sans MT is included within the package itself. Give it a spin :)

restrellado commented 4 years ago

@jrosen48 did this work?