search

data-edu / tidyLPA

Easily carry out Latent Profile Analysis (LPA) using open-source or commercial software
https://data-edu.github.io/tidyLPA/
Other
55 stars 15 forks source link

R CMD check warning #202

Open jrosen48 opened 6 months ago

jrosen48 commented 6 months ago

@cjvanlissa, to my great shame, I am just now getting version 2.0.1 on CRAN. I am seeing this warning. I think it relates to the import of functions from tidySEM - agree or not?

❯ checking S3 generic/method consistency ... WARNING
  plot_bivariate:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list, ...)
  plot_bivariate.tidyLPA:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list)

  plot_bivariate:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list, ...)
  plot_bivariate.tidyProfile:
    function(x, variables, sd, cors, rawdata, bw, alpha_range,
             return_list)
  See section ‘Generic functions and methods’ in the ‘Writing R
  Extensions’ manual.
cjvanlissa commented 6 months ago

Dear Josh, I don't think I "delivered" a ready-for-CRAN dev version; I did make some necessary changes and functional upgrades, but these all require checking. I can contribute to that after March 26th, but not now unfortunately. Just looking at the warning above, all you need to do is add ... to the arguments of the method plot_bivariate.tidyLPA and plot_bivariate.tidyProfle so that they have the same arguments as the generic.

jrosen48 commented 6 months ago

Thanks. Maybe we can touch base after March 26th - I can definitely work on writing unit tests and doing additional documentation (edits to README and vignette and possibly examples/roxygen2 work). Are those the main tasks in your view?