Closed johanols closed 9 months ago
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
a6d0bbe
) 0.00% compared to head (104ad9f
) 0.00%. Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
minimalkv/decorator.py | 0.00% | 4 Missing :warning: |
minimalkv/_key_value_store.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
The previous return type of
Iterable
is incorrect as can be seen in this example: https://docs.python.org/3/library/typing.html#nominal-vs-structural-subtypingAlso this documentation mentions that
__iter__
returns the iterator object itself: https://docs.python.org/3/library/stdtypes.html#iterator.__iter__The incorrect
Iterable
type causes numerous of error when analyzed by a static type checker such asmypy
. The switch toIterator
solves these issues.Checklist
docs/changes.rst
entry