data-exchange / dxchange

data exchange supporting tomopy
http://dxchange.readthedocs.io
Other
34 stars 42 forks source link

report for aps_1id data and vtk writing support #74

Closed KedoKudo closed 5 years ago

KedoKudo commented 5 years ago

Add a function to generated report based on the metadata from aps_1id tomography experiment, and a function to export reconstruction results to VTK (vtr, rectangular grid).

decarlof commented 5 years ago

@KedoKudo may you give me a test data set so I can see how the report function works? This could be interesting to add to other beamline

KedoKudo commented 5 years ago

@decarlof Should I put the test data in the test/test_data folder?

decarlof commented 5 years ago

no too big for github. Please send me an email and I will give you an upload link

On Mon, Nov 19, 2018 at 9:26 AM Chen notifications@github.com wrote:

@decarlof https://github.com/decarlof Should I put the test data in the test/test_data folder?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/data-exchange/dxchange/pull/74#issuecomment-439931230, or mute the thread https://github.com/notifications/unsubscribe-auth/AFnI9ikv3Mb4ON0yXTiWsvWcoHpHyxoVks5uws2xgaJpZM4YcZnB .

decarlof commented 5 years ago

thank you for the files @KedoKudo . What you are proposing is a very good idea, I have just two suggestions:

  1. rename the report_aps_1id as write_aps_1id_report and move it in the writer.py module
  2. move the "import matplotlib.pyplot as plt" inside the write_aps_1id_report function as for now it is only used there.

I think 1. will encourage other to add their report writers there and it is a matter of fact I already had a sort of write_32_id_report that I wasn't sure where to put. Now I do! Thanks again

KedoKudo commented 5 years ago

@decarlof I moved the report function to writer.py as suggested. Please let me know if there is anything else that needs to be done before merging.

decarlof commented 5 years ago

@KedoKudo perfect, thanks