search

data-exp-lab / girder_ythub

Girder plugin enabling intergration with tmpnb
BSD 3-Clause "New" or "Revised" License
3 stars 10 forks source link

Separate public tmpnb url from internal tmpnb url #4

Closed Xarthisius closed 7 years ago

Xarthisius commented 7 years ago

In case when girder communicates with a proxy over a private network (via tmpnb_url), we need to use a different url for accessing notebooks.

codecov[bot] commented 7 years ago

Codecov Report

Merging #4 into master will increase coverage by 0.79%. The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
+ Coverage   93.79%   94.58%   +0.79%     
==========================================
  Files           7        7              
  Lines         419      425       +6     
==========================================
+ Hits          393      402       +9     
+ Misses         26       23       -3
Impacted Files Coverage Δ
server/rest/ythub.py 100% <100%> (ø) :arrow_up:
server/constants.py 94.11% <100%> (+0.36%) :arrow_up:
server/__init__.py 91.09% <90%> (+2.2%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 806a6f3...e3b4502. Read the comment docs.