search

data-for-change / anyway-tasks

MIT License
0 stars 0 forks source link

Widget: Update accident_count_by_accident_type widget #1

Open ziv17 opened 2 years ago

ziv17 commented 2 years ago

This issue is to coordinate the work on BE issue 2122 with same name: Name Required changes to widget accident count by accident type

Title accident_count_by_accident_type widge

Required changes • Add Title - years and widget name to heading (BE & FE) • Add filter “top 3 types” results (BE) • Pie will display only “top 3 types” results (FE) • Enlarge pie size (FE) • Remove years details below (?) • Add information text (BE)

Visualization explanation New display image

Current display image

Use case When this infographic should be displayed: allways

Information Tag Will include the following description: התפלגות תאונות לפי סוג התאונה במקטע, בפרק הזמן הנבחר. מוצגים 3 סוגי התאונות הנפוצים ביותר במקטע זה.

Additional context

Definition will be used by BE team to generate a Json response to FE
Definition will be provided by Data team, after internal review
Definition will be written in English and should use language agnostic definitions and data structures
(e.g. SQL columns) as much as possible.
danielsh28 commented 2 years ago

@ziv17 @MichalOren are these changes also apply to accident_count_by_driver_type? or maybe just some of them? we have an issue in progress on that https://github.com/hasadna/anyway-newsflash-infographics/issues/859

MichalOren commented 2 years ago

Hi @danielsh28 we usually open issues per widget. Even if the changes are similar or identical, just to avoid any misunderstanding. etch widget is in a different stage of implementation

MichalOren commented 2 years ago

this is the original link with wireframe https://github.com/hasadna/anyway/issues/2122