data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
75 stars 242 forks source link

Add new location type: intersection #2257

Open MichalOren opened 1 year ago

MichalOren commented 1 year ago

Location types: Currently we have two types of locations: -Intercity segment -A street within a settlement We would like to add new location types: -Intercity intersection -Urban intersection

Purpose A road network can be divided into 2 objects, a segment and a node. Adding intersection objects allows displaying information about accidents in an additional dimension

Definitions: interchange & intersection & junction They can be in the city and in Intercity roads. For us right now, the size does not matter but the type of space in which they are located To create a common language we will use the term "intersection": -Intercity intersection -Urban intersection

Use case For each news-flash we decide what type of location it is. So the decision needs to be changed to a node location types

Database In involved_markers_hebrew table, we have non_urban_intersection, non_urban_intersection_hebrew, urban_intersection fields (i think this is one for all intersection types. if not, kindly update me or this issue)

Additional context Atalya & Ziv, Do you have any additional highlights? before assign it to a volunteer

ziv17 commented 1 year ago

Hi @MichalOren , in the code we already use the terms SUBURBAN and URBAN. It will be easier to stay with it.

ziv17 commented 1 year ago

Hi @atalyaalon , Can we get list of all junctions from למ"ס? (codes, names, and roads/yishuv_symbols? We need to be able to translate codes to names and vice versa

MichalOren commented 1 year ago

Hi @ziv17 Continuity and consistency is my intention. please use the terms SUBURBAN and URBAN. regarding " list of all junctions" i have query but I can't connect to the database since we moved to the new servers

ziv17 commented 1 year ago

Hi, Junction locations have two roads, e.g. 17 and 19. Some will specify road1==17 and road2=19, and others will specify road1==19 and road2==17. I suggest, that in our widgets, we will include all accidents from that junction, regardless of the order of roads. What do you think?

ziv17 commented 1 year ago

A similar issue is with junctions that have 3 or more roads. I suggest that for non urban junctions, we will write the junction name, and not specify the road names. What do you think?

ziv17 commented 1 year ago

Regarding urban junctions with 3 or more streets.

MichalOren commented 1 year ago

Hi @ziv17 i think it easier to start with suburban junction and handle urban in further step

ziv17 commented 1 year ago

Hi Michal, OK, I will do.

On Monday, January 2, 2023 at 09:21:24 PM GMT+2, MichalOren ***@***.***> wrote:  

Hi @ziv17 i think it easier to start with suburban junction and handle urban in further step

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>