data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
77 stars 244 forks source link

recreate location extraction table in CBS #2563

Closed atalyaalon closed 9 months ago

atalyaalon commented 10 months ago

I looked in code and it seems this table does not update, I think we should update it every time we're updating CBS data since it's dependent on it

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (8f3209c) 52.94% compared to head (a1f50c7) 52.98%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2563 +/- ## ========================================== + Coverage 52.94% 52.98% +0.04% ========================================== Files 119 119 Lines 9819 9821 +2 ========================================== + Hits 5199 5204 +5 + Misses 4620 4617 -3 ``` | [Flag](https://app.codecov.io/gh/data-for-change/anyway/pull/2563/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/data-for-change/anyway/pull/2563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `52.98% <100.00%> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

atalyaalon commented 9 months ago

@ziv17 for a specific newsflash - it's used for it's location extraction - to get from GPS (after geocoding using google) the correct street/segment