data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
77 stars 244 forks source link

Removing location textual fields indices from tables of db_views.py file #2676

Open atalyaalon opened 5 months ago

atalyaalon commented 5 months ago

That's for the next milestone, but I want to keep documentation of this issue as we spoke about it in our last meeting

We can first:

And then:

ziv17 commented 2 months ago

Hi @atalyaalon We want to add the numeric indexes if they do not exist, right? (e.g. involved_markers_hebrew does not have street2 index.

atalyaalon commented 2 months ago

@ziv17 yes you are right. And in table involved_markers_hebrew we also want to remove the street1_hebrew, street1_hebrew, accident_yishuv_name , road_segment_name, as you performed in this pr

ziv17 commented 1 month ago

Hi @atalyaalon , The 5 tables that are created in db_views.py are:

Are these the tables that I should work on?

ziv17 commented 1 month ago

Hi @atalyaalon , I might have asked you this already. If so, I apologize 😄 Currently the infographics API can accept text field as filters, and it replaces them with the corresponding numeric field. For this, it does a select with the given text field. If we keep this functionality, do we still want to remove the text indexes?

atalyaalon commented 3 weeks ago

@ziv17 can you add the like to the relevant code that does a select with the given text field?