search

data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
77 stars 244 forks source link

2669 improve location accuracy for street newsflashes #2708

Open tkalir opened 1 month ago

atalyaalon commented 1 month ago

@tkalir no urgency here, whenever you have time - can you please check and fix Pylint, Black and failing tests?

atalyaalon commented 1 month ago

@ziv17 can you review this one as well? (No urgency here) I want to make sure I didn't miss anything in edge cases

atalyaalon commented 1 month ago

@tkalir I added key to secrets. Note that github-secrets are not accessible for PRs from forks, therefore tests in this PR will fail, but in merging dev to master they will not. However, we do want to enable tests running from forks, henece I suggest wrap the secret in a function, to avoid tests failures in tests from forks