data-for-change / anyway

ANYWAY - Car accidents map
http://www.anyway.co.il
MIT License
77 stars 242 forks source link

Option for user to add link/picture to an existing marker #51

Open galraij opened 10 years ago

galraij commented 10 years ago

Let people add data to a specific marker-

  1. User log in with Facebook.
  2. User find a specific marker and open its pop-up window.
  3. User add a link to an article/web page/upload a picture.
  4. The picture/link is associated with the user (like the other data is associated with the Lamas)
  5. ANYWAY shares his action on his wall: "User added a picture to accident in Tel Aviv"

marker_add_data_psd___100___ _ __rgb_8_

galraij commented 9 years ago

Are we getting closer to the stage we can make this happen?

Maybe we can use disqus for it (since we already "know" how to link between a disqus discussion and a specific marker)

Disqus let user add pictures and links which is exactly what we need. How customized can the disqus feature be? we need:

  1. A possibility to limit users (for example let the NGOs have user name and only them can add information).
  2. Make the design of the disqus feature minimal (no links to other discussions at the buttom, less distraction in general, no option to comment unless you are logged in).

Maybe the solution will be to open another disqus account just for this purpose.

danielhers commented 9 years ago

We know how to create a discussion marker at a given location, and it shouldn't be hard to be able to associate a Disqus thread with any accident marker: as a first stage, we can just add a link in the info window to open the discussion modal. The identifier can be the id of the accident marker. Should be easy, it's just some Javascript with no server-side work at all.

I don't know how to only let specific users comment, though. About the design, I don't know. Need to check in the documentation.

On Wed, May 20, 2015 at 4:47 PM Gal Raij notifications@github.com wrote:

Are we getting closer to the stage we can make this happen?

Maybe we can use disqus for it (since we already "know" how to link between a disqus discussion and a specific marker)

Disqus allow to add a pictures and links which is exactly what we need. How customized can the disqus feature be? we need:

1.

A possibility to limit users (for example let the NGOs have user name and only them can add information). 2.

Make the design of the disqus feature minimal (no links to other discussions at the buttom, less distraction in general, no option to comment unless you are logged in).

Maybe the solution will be to open another disqus account just for this purpose.

— Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/51#issuecomment-103894185.

galraij commented 9 years ago

so it might be a good task for someone new at the Hackaton

danielhers commented 9 years ago

Definitely

On Wed, May 20, 2015 at 4:54 PM Gal Raij notifications@github.com wrote:

so it might be a good task for someone new at the Hackaton

— Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/51#issuecomment-103895537.

galraij commented 9 years ago

also- maybe Facebook comments will be a possibility as well. I think user control is easier there.

danielhers commented 9 years ago

Maybe, but I don't know how to do that. Facebook integration didn't really work (except for like and share). We replaced that with Disqus.

On Wed, May 20, 2015 at 4:56 PM Gal Raij notifications@github.com wrote:

also- maybe Facebook comments will be a possibility as well. I think user control is easier there.

— Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/51#issuecomment-103895863.

galraij commented 9 years ago

Is this she solution? (or what proves there is no solution?) https://help.disqus.com/customer/portal/questions/8440448-can-you-restrict-login-to-sso-only-

danielhers commented 9 years ago

There's no solution there...

On Wed, May 20, 2015 at 5:09 PM Gal Raij notifications@github.com wrote:

Is this she solution? (or what proves there is no solution?)

https://help.disqus.com/customer/portal/questions/8440448-can-you-restrict-login-to-sso-only-

— Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/51#issuecomment-103900718.

galraij commented 9 years ago

OK, I think I have found a solution that might work:

  1. We open a new Disqus account.
  2. In settings we cancel guest comments + in pre-moderation choose ALL so we have to approve comments. (see screen shot). general_-_settings_-_disqus
  3. We open accounts for the NGOs or specific users and put them in the White list- if it's not enough to bypass the approval we will just have to approve each comment when it arrives.
danielhers commented 9 years ago

That could work. Maybe Disqus allows different configurations per shortname or URL within the same account though? On May 20, 2015 5:26 PM, "Gal Raij" notifications@github.com wrote:

OK, I think I have found a solution that might work:

  1. We open a new Disqus account.
  2. In settings we cancel guest comments + in pre-moderation choose ALL so we have to approve comments. (see screen shot). [image: general_-settings-_disqus] https://cloud.githubusercontent.com/assets/3368312/7727986/25eba9c2-ff15-11e4-83c2-7f24eb3bcf03.jpg
  3. We open accounts for the NGOs or specific users and put them in the White list- if it's not enough to bypass the approval we will just have to approve each comment when it arrives.

— Reply to this email directly or view it on GitHub https://github.com/hasadna/anyway/issues/51#issuecomment-103904983.

samuelregev commented 9 years ago

You can use as many short_names as you want in the same domain (as far as I know). also you can disable the windows that shows other discussion in the settings

uploads/a309246c-a188-4349-bfcd-a8914db720b7/blob

aviklai commented 9 years ago

@eladkarakuli Can you help with this issue? We want to add a discussion to a marker so we need to open the discussion view from the marker view and create a combined view with a marker details and discussion details for markers that already have a discussion.

njenia commented 9 years ago

We discussed this issue in person with @galraij and @aviklai and decided to create our own user management system instead of using facebook or other stuff. Maybe facebook authentication will be added in the future.

So basically if the user is logged in and authorized to embed media to markers (I don't see why this should be restricted to certain roles only) he will be presented in the marker info window an embed button. This button will allow him to embed urls (probably using embed.ly).

The next step is allowing images and videos I guess.

galraij commented 9 years ago

Authorizes user can:

  1. Add text (and his name will be presented next to it similar to Facebook comments).
  2. Add URL (and a thumbnail will be generated using embed.ly or similar).
  3. Add picture/video (Not urgent- Do not delay the others for this).
galraij commented 9 years ago

Here is a good example of embedding URL on the Hasadna Forum (I guess it's open source): http://forum.hasadna.org.il/t/topic/318 _ _ _ _ _ _ - _-_ ___anyway_-_ _ I think the platform called discourse. Embed.ly at some point cost money, so if possible we would prefer copying what they did.

simonaho commented 8 years ago

@kerennem are you still working on this?

kerennem commented 8 years ago

Yes