search

data-forge / data-forge-ts

The JavaScript data transformation and analysis toolkit inspired by Pandas and LINQ.
http://www.data-forge-js.com/
MIT License
1.34k stars 77 forks source link

Rollup support #16

Closed andriilahuta closed 5 years ago

andriilahuta commented 6 years ago

Rollup generates a lot of Circular dependency warnings and produces a broken bundle with undefined variables. Single-file bundle could probably resolve this issue.

ashleydavis commented 6 years ago

Yes! Single bundle is definitely on the horizon in the next couple of months.

Thanks for letting me know.

ashleydavis commented 5 years ago

I don't know about rollup, but this module works well with Browserify and Webpack.

I've now included a single bundle in the npm module under the directory /dist/web.

Please see "From the browser" instructions in the readme.

The repo also include webpack.node.config.js that you can use to bundle Data-Forge for use under Node.js.

andriilahuta commented 5 years ago

Web version works with rollup, but I have to replace var dataForge with export const dataForge to be able to import it properly. Could you bundle esm browser build as well? Related issue: #33.

ashleydavis commented 5 years ago

If you know how to bundle for esm please do that and submit a PR.