data-gov / bumblebee

Analisador de dados responsavel por importar para o BD dados sobre Deputados
GNU General Public License v3.0
1 stars 2 forks source link

refactor: cria abstracao para todas as chamadas a API dados abertos #11

Closed eduardomoroni closed 6 years ago

eduardomoroni commented 6 years ago

Este PR adiciona Iterardor de OpenDataResponse<T> possibilitando percorrer facilmente cada resposta da API até o fim.

Adiciona tambem a implementaçāo das abstraçōes para ExpenseModelClient, agora é possível retornar TODAS as despesas de um deputado 🙌🏽

codecov-io commented 6 years ago

Codecov Report

Merging #11 into master will decrease coverage by 5.88%. The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #11      +/-   ##
============================================
- Coverage       100%   94.11%   -5.89%     
- Complexity        8       15       +7     
============================================
  Files             6        8       +2     
  Lines            38       51      +13     
  Branches          0        3       +3     
============================================
+ Hits             38       48      +10     
- Partials          0        3       +3
Impacted Files Coverage Δ Complexity Δ
...om/bumblebee/congressman/service/ExpenseService.kt 100% <100%> (ø) 2 <0> (ø) :arrow_down:
.../com/bumblebee/congressman/mapper/ExpenseMapper.kt 100% <100%> (ø) 0 <0> (ø) :arrow_down:
.../bumblebee/congressman/service/OpenDataIterator.kt 71.42% <71.42%> (ø) 5 <5> (?)
...blebee/congressman/service/ExpenseLinkNavigator.kt 83.33% <83.33%> (ø) 2 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0aaee2...16192a4. Read the comment docs.