search

data-gov / bumblebee

Analisador de dados responsavel por importar para o BD dados sobre Deputados
GNU General Public License v3.0
1 stars 2 forks source link

refactor: Reorganiza pacotes para desenvolvimento api de eleicoes #15

Closed realsuiciniv closed 6 years ago

realsuiciniv commented 6 years ago

Proposta de organização de pacotes:

screen shot 2017-10-20 at 07 50 17
realsuiciniv commented 6 years ago

Provavelmente a cobertura de código caia um pouco porque criei um exemplo de client / service para api das eleiçoes

eduardomoroni commented 6 years ago

O codacy pendurou denovo ☹️ @viniciusrdacosta poderia verificar porque o teste quebrou?

codecov-io commented 6 years ago

Codecov Report

Merging #15 into master will decrease coverage by 0.35%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #15      +/-   ##
============================================
- Coverage     84.02%   83.67%   -0.36%     
- Complexity       31       32       +1     
============================================
  Files            12       13       +1     
  Lines           144      147       +3     
  Branches          4        4              
============================================
+ Hits            121      123       +2     
- Misses           17       18       +1     
  Partials          6        6
Impacted Files Coverage Δ Complexity Δ
...umblebee/api/congressman/service/ExpenseService.kt 35.71% <ø> (ø) 4 <0> (?)
...pi/congressman/service/CongressmanLinkNavigator.kt 100% <ø> (ø) 2 <0> (?)
...ee/api/congressman/service/ExpenseLinkNavigator.kt 83.33% <ø> (ø) 2 <0> (?)
...ebee/api/congressman/service/CongressmanService.kt 81.81% <ø> (ø) 7 <0> (?)
.../bumblebee/api/congressman/mapper/ExpenseMapper.kt 100% <ø> (ø) 0 <0> (?)
...blebee/api/congressman/mapper/CongressmanMapper.kt 100% <ø> (ø) 0 <0> (?)
...blebee/api/congressman/service/OpenDataIterator.kt 90% <ø> (ø) 7 <0> (?)
...e/configuration/feign/decoder/FeignErrorDecoder.kt 33.33% <ø> (ø) 1 <0> (?)
.../bumblebee/api/congressman/client/ExpenseClient.kt 100% <ø> (ø) 0 <0> (?)
...umblebee/configuration/feign/FeignConfiguration.kt 66.66% <ø> (ø) 6 <0> (ø) :arrow_down:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a8c3f6...16cb575. Read the comment docs.

realsuiciniv commented 6 years ago

O codacy pendurou denovo ☹️ @viniciusrdacosta poderia verificar porque o teste quebrou?

Codacy tá nos quebrando. Muito lento pra ter feedback dele :(

O teste quebrou pq adicionei uma property no yml e nao coloquei no integration-yml

eduardomoroni commented 6 years ago

dale!