Closed jbothma closed 6 years ago
Parts of this code are being pulled into CKAN, however some of the features are more opinionated than should be in CKAN. Additionally maintaining a plugin over the short term is significantly easier than a series of patches to core CKAN.
Awesome. Thanks!
On Wed, 14 Mar 2018, 22:51 Lee Symes notifications@github.com wrote:
Parts of this code is being pulled into CKAN, however some of the features are more opinionated than should be in CKAN. Additionally maintaining a plugin over the short term is significantly easier than a series of patches to core CKAN.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/data-govt-nz/ckanext-security/issues/12#issuecomment-373170299, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOZGZiI_IjePl-HhhT8tuCWS5aJ85diks5teYLMgaJpZM4SqAr9 .
@jbothma see #2 We'd still be keen to take parts of this module and move into pull requests on core. We may need a hand to prep the pull requests and review them if you're up for helping out?
I'm going to close this issue but feel free to pick the conversation back up in #2
Oh man I just totally looked past #2 when asking my question. Sorry :)
This sounds important.
Why is this a plugin and not a pull request to CKAN?