data-govt-nz / ckanext-security

A CKAN extension to hold various security improvements for CKAN
GNU Affero General Public License v3.0
25 stars 31 forks source link

Use /api path for ajax login call #39

Closed markstuart closed 3 years ago

markstuart commented 3 years ago

CKAN has special response middleware that overrides the content/body of the response for certain status codes. However, it does not apply on routes under the /api paths so we can make sure the response type can be consistently json regardless of the status code.

ThrawnCA commented 3 years ago

@markstuart I can't speak for the repository owners, but my understanding is that force-pushes are generally problematic. For example, I received a Github notification of your changes, but when I followed it, Github couldn't find the relevant commits, because you had overwritten the commit history. And it couldn't show me "all changes since you last reviewed", either, since again, that was all overwritten. I'm thinking it would be better to just have merge commits.