Clean up and prep for Python 3

data-govt-nz / ckanext-security

A CKAN extension to hold various security improvements for CKAN

GNU Affero General Public License v3.0

25 stars 31 forks source link

Clean up and prep for Python 3 #44

Closed ThrawnCA closed 2 years ago

ThrawnCA commented 3 years ago

Fix Flake8 errors
Use 'six' module to improve Python 3 compatibility, #35

ThrawnCA commented 3 years ago

Looks good to me @ThrawnCA, are you aware of anything else that will need attention for Python 3 compatibility?

Not that I'm aware of. I can't make any promises about CKAN 2.9, but Flake8 under Python 3 was happy with this, so the syntax is probably okay on that front.

ThrawnCA commented 3 years ago

@markstuart I've done some work this week on adapting our CSRF filter to Flask. That's something that will need to happen on a larger scale for ckan 2.9; everything in controllers.py will need to be converted to blueprints.

On the bright side of things, Flask provides better hooks, making the middleware patch unnecessary.

ThrawnCA commented 3 years ago

@markstuart NB I can't merge this myself.