data-govt-nz / ckanext-security

A CKAN extension to hold various security improvements for CKAN
GNU Affero General Public License v3.0
25 stars 32 forks source link

Fix memcached client import path #5

Closed bzar closed 6 years ago

bzar commented 7 years ago

The suggested commit to add CSRF middleware silently fails. This should be addressed separately.

The import fails because ckanext.security.middleware imports from the wrong path ckanext.security.memcached, which should be ckanext.security.cache.clients.

camfindlay commented 7 years ago

Cheers for this @bzar - will check back with devs to look into this. Any cross over between this and #6 ?

bzar commented 7 years ago

No. Before applying this patch the CSRF middleware was never loaded. The import error was just silently discarded.

anotheredward commented 6 years ago

Thanks for catching this @bzar !