search

data-govt-nz / ckanext-security

A CKAN extension to hold various security improvements for CKAN
GNU Affero General Public License v3.0
25 stars 32 forks source link

Patch information in README is ambiguous #7

Closed devenson closed 6 years ago

devenson commented 6 years ago

I'm having trouble tracking down this required patch:

"Session- and CSRFMiddleware need to be placed at the bottom of the middleware stack. This requires to patch ckan.config.middleware.pylons_app. The patch is currently available in the Catalyst CKAN repository on the catalyst/dia branch, or commit 74f78865 for cherry-pick."

Can you link to the specific commit or provide an inline example of the patch?

camfindlay commented 6 years ago

Hey @devenson I think the commit being referred to here is living at https://github.com/data-govt-nz/ckan/commit/74f78865b8825c91d1dfe6b189228f4b975610a3 - a fork of the ckan repo (was once on an internal repo now open sourced).

I've amended the docs to help in the future, many thanks for letting us know about the confusion 👍

devenson commented 6 years ago

@camfindlay - I did end up finding it once I realized that the data-govt-nz github account was being referred to as "Catalyst". Thanks for the help.