[PLUGIN-1740] Added Wait Time Between Request Field in HTTP Sink

[psainics]

Added Wait Time Between Request Field in HTTP Sink

Jira : Plugin-1740

Description

Read Timeout (milliseconds) field is incorrectly being used for delay between requests, a new field is added to define delay between requests.

UI Fields changes

• A new UI field is added Wait Time Between Request (milliseconds)

Docs

• docs for new field added

  Wait Time Between Request: Time in milliseconds to wait between HTTP requests. Defaults to 0.

Code change

• Move wait between request field to base HTTP as same functionality is being used in HTTP source and HTTP sink
• Change wrong field being used for delay.

[psainics]

@anup-cloudsufi The field is used as a parameter for the Awaitility library, in pollDelay !

The Unit test for this is not possible. Are you referring to some other code ?

Awaitility.await().with()
.pollInterval(pollInterval)
.pollDelay(config.getWaitTimeBetweenPages(), TimeUnit.MILLISECONDS)
.timeout(config.getMaxRetryDuration(), TimeUnit.SECONDS)
.until(this::executeHTTPServiceAndCheckStatusCode);

[anup-cloudsufi]

Based on our discussion it seems it will take more to time to add unit test for it as the existing unit tests are only for macro and non-macro plugin config values and not for other features. We should take this separately to add these tests.