data-integrations / multi-table-plugins

Pipeline plugins that allow reading from multiple DB tables with the same source
0 stars 10 forks source link

[CDAP-17082] Add support for decimal type #25

Closed CuriousVini closed 4 years ago

CuriousVini commented 4 years ago

is there any unit test that needs to be changed? If not, is there an easy way to add a test for this?

There is no existing unit test for DBTypes class. The way current code is structured, each method takes ResultSet or ResultSetMetaData makes it little harder to add unit test without refactoring the code.

I have verified the fix manually on cluster: image

image