this plugin doesn't work for mysql database

data-integrations / multi-table-plugins

Pipeline plugins that allow reading from multiple DB tables with the same source

0 stars 10 forks source link

this plugin doesn't work for mysql database #8

Open yohayg opened 6 years ago

yohayg commented 6 years ago

The mysql driver doesn't return the database name. I have a branch ready

yohayg commented 6 years ago

please give me permission to open a new feature branch

nitinmotgi commented 6 years ago

Fork the repo into your account, make changes and then submit a PR.

albertshau commented 6 years ago

I ran into the same issue and have a fix on https://github.com/data-integrations/multi-table-plugins/pull/7, along with changes to support date/time types, though it also bumps the versions up to latest

yohayg commented 6 years ago

Hi, The latest merge to develop branch fixed the mysql issue. However the co.cask.plugin.PipelineTest is failing due to: java.lang.IllegalArgumentException: Name 'PUBLIC.MULTI2-47fedc9d-c01b-4149-857e-71eb69b65199' must consist only of ASCII letters, numbers, _, or -. I'll just submit the mysql test. I'll open a new PR