search

data-liberation-project / phmsa-hazmat-incident-reports

Data from decades of PHMSA's "5800.1" hazardous material transportation incident reports
https://www.data-liberation-project.org/datasets/phmsa-hazmat-incident-reports/
7 stars 3 forks source link

Adding date validation #7

Closed gcappaert closed 1 year ago

gcappaert commented 1 year ago

This should do it! I made an 'oops' pull request earlier that I closed because I'm still getting the hang of Github. The f-strings in the exceptions are not really necessary, just add to clarity. I know it's a controversial move :)

jsvine commented 1 year ago

Super, thanks! Now merged. Have also added you to the README's (new) contributors list.

I'm a fan of f-strings, FWIW. In fact, made a couple of small tweaks to take further advantage of them (i.e., adding zero-padding to the months): https://github.com/data-liberation-project/phmsa-hazmat-incident-reports/commit/e6bfa4860e7f620c59a88c5d632434cca53a67f0