Closed jeremyyeo closed 2 years ago
The PR looks great, nice work @jeremyyeo! :)
Adding tests : You can add a new command test case in conftest.py. You'll need to create an example response JSON file in the tests/data/ folder (e.g., tests/data/run_cancel_response.json
). Let me know if you need more assistance.
Figuring out what to do when the --run-id targets a run that has already succeeded / errored - should we check that a job is currently running / queued / starting before cancelling?: If the run has finished (success or error) the cancel request will just return a success response, right? I don't see any problem with that.
This all looks great! Thanks for your contribution @jeremyyeo ❤️
Description & motivation
Hey @stumelius, sweet package 😄 - keen to contribute to #29
Could use some help:
--run-id
targets a run that has already succeeded / errored - should we check that a job is currently running / queued / starting before cancelling?Checklist