data-mie / dbt-profiler

Macros for generating dbt model data profiles
Apache License 2.0
81 stars 33 forks source link

Add `where_clause` argument to macros #57

Closed dweaver33 closed 2 years ago

dweaver33 commented 2 years ago

Description & motivation

This will allow a user to specify a WHERE clause so the user can filter out which data to profile.

Checklist

dweaver33 commented 2 years ago

@stumelius, first attempt. Let me know if there's any changes needed.

stumelius commented 2 years ago

@dweaver33 Great work, the code looks good! I left a few comments for you.

dweaver33 commented 2 years ago

@stumelius, I think you need to mark your review as finished so I can see the comments.

stumelius commented 2 years ago

@dweaver33 Lol, my bad 🤦 There you go!

dweaver33 commented 2 years ago

I only know that you have to finish the review because I've done it myself. 😅