data-platform-hq / mlflow-oidc-auth

MLFlow Tracking Server OIDC Auth plugin
https://pypi.org/project/mlflow-oidc-auth/
Apache License 2.0
25 stars 11 forks source link

fix: auth_client token generation #23

Closed mt-czi closed 3 months ago

mt-czi commented 6 months ago

The token_prepare_request method for oauth library fails. The code is passing the authorization url without the attributes containing the code value. This raises an error from the oauth library complaining no code was passed. However we do do pass the actual code as a separate parameter. So removing the authorization_url parameter fixes the issue.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

kharkevich commented 6 months ago

hello @mt-czi, thanks for the PR,

Could you please provide a little bit more details, Unfortunately, for all my test cases, I have no issue mentioned by you

kharkevich commented 3 months ago

The issue was closed as stale due to prolonged inactivity