data-platform-hq / terraform-azurerm-mssql-server

Terraform module for managing Azure SQL Server
https://registry.terraform.io/modules/data-platform-hq/mssql-server/azurerm/latest
Other
1 stars 1 forks source link

wrong data block is called in the Usage example | https://registry.terraform.io/modules/data-platform-hq/mssql-server/azurerm/latest #16

Open sushmitapandey opened 2 months ago

sushmitapandey commented 2 months ago

In the Usage example in the https://registry.terraform.io/modules/data-platform-hq/mssql-server/azurerm/latest, the data block in the module mssql_server for the attribute "key_vault_key_id" is incorrect.

data "azurerm_key_vault" "example" { name = "example" resource_group_name = "example" }

data "azurerm_key_vault_key" "example" { name = "example" key_vault_id = data.azurerm_key_vault.example.id }

module "mssql_server" { source = "data-platform-hq/mssql-server/azurerm" version = "1.2.0"

project = "datahq" env = "example" location = "eastus" resource_group = "example" admin_login = "userexample" admin_password = "passwordexample" azure_ad_admin_login = "ad_userexample@example.com" azure_ad_admin_object_id = "" ip_rules = {
"example" = "55.55.60.0/24" }

tde_key_permissions = true key_vault_id = data.azurerm_key_vault.example.id key_vault_key_id = data.azurerm_key_vault.example.id --> data.azurerm_key_vault_key.example.id

mssql_defender_state = "Disabled" }

owlleg6 commented 2 months ago

Thanks, will update docs in example!