data-solution-automation-engine / virtual-data-warehouse

The Virtual Data Warehouse is a code generation and template management tool. It is part of the data solution automation ecosystem - the 'engine' for data solution automation.
https://github.com/RoelantVos/Virtual-Data-Warehouse
GNU Lesser General Public License v3.0
45 stars 13 forks source link

Index out of bounds of the array #14

Closed nicolaspirmez closed 3 years ago

nicolaspirmez commented 3 years ago

Hello Roelant,

Thank you for your great work regarding VDW, very insightful.

I noticed a bug when trying to generate the presentation layer (Dimension / PIT 001 Select Pattern), with VDW 1.6.5: image

Best regards,

Nicolas

RoelantVos commented 3 years ago

Hi Nicolas,

Thanks for bringing this to my attention. I’ll have a look what the matter is over the weekend.

Kind regards,

Roelant

From: Nicolas Pirmez @.> Sent: Sunday, 15 August 2021 16:20 To: RoelantVos/Virtual-Data-Warehouse @.> Cc: Subscribed @.***> Subject: [RoelantVos/Virtual-Data-Warehouse] Index out of bounds of the array (#14)

Hello Roelant,

Thank you for your great work regarding VDW, very insightful.

I noticed a bug when trying to generate the presentation layer (Dimension / PIT 001 Select Pattern), with VDW 1.6.5: https://user-images.githubusercontent.com/16762415/129469145-d80fbbc6-957f-4583-a838-20df5cb7e791.png

Best regards,

Nicolas

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/RoelantVos/Virtual-Data-Warehouse/issues/14 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHRXHVNXBWJR6B4XSOURIXLT45MABANCNFSM5CF3FPTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email . https://github.com/notifications/beacon/AHRXHVINWD7S3EA3BFTXYLDT45MABA5CNFSM5CF3FPT2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4OPBG7CA.gif

RoelantVos commented 3 years ago

Hi Nicolas, thanks again for reporting this issue. I had a look (finally, I was away for some time) and the issue is that there is a superfluous {{/each}} statement in the Handlebars template. Removing it does the trick. Not sure what happened there, must have been a last copy/paste.

image

In any case, I've committed this to master and created a new release.