search

data-to-insight / csc-validator-be-903

Python-side code for the Quality LAC Data Beta frontend
https://903.datatoinsight.org
MIT License
8 stars 4 forks source link

Add rule 217t to 23/24 #715

Closed SLornieCYC closed 1 year ago

SLornieCYC commented 1 year ago

Closes #632

codecov-commenter commented 1 year ago

Codecov Report

Merging #715 (e3fb172) into main (d52d79f) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main     #715   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         309      309           
  Lines        7516     7516           
=======================================
  Hits         7177     7177           
  Misses        339      339

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SLornieCYC commented 1 year ago

Thanks Will; yes line 42 should fail because it's an open episode (no end date) after the date that placement type has ceased to be valid.

SLornieCYC commented 1 year ago

I guess this is why squash merge is a thing! Next time I'm gonna use that (or make sure all my commits have sensible titles).

image