data-to-insight / csc-validator-be-903

Python-side code for the Quality LAC Data Beta frontend
https://903.datatoinsight.org
MIT License
8 stars 4 forks source link

SW01STG1 #739

Closed WillLP-code closed 6 months ago

WillLP-code commented 10 months ago

closes #669

DfE Long-form description of error If the child is looked after on 31 March then social worker episodes data should be reported for the child. Check that social worker ID, team and episode start and end dates have all been entered.

DfE suggested coding If then at least one instance of each of the following items should be provided: , ,

I'm, once again, not convinced that the suggested coding and the long form description mean the same thing, but this is coded according to the DfE coding.

Logic: if a child passes the criteria to be looked after 31 march, they need to have at least one of each of ID, DECOM, and REASON (meaning they need to have all three because of the 'each of')

Update:

closes #701

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.30%. Comparing base (15179c5) to head (90eaafa). Report is 54 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #739 +/- ## ========================================== + Coverage 95.27% 95.30% +0.02% ========================================== Files 313 314 +1 Lines 7717 7766 +49 ========================================== + Hits 7352 7401 +49 Misses 365 365 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WillLP-code commented 10 months ago

now additionally closes #701

SLornieCYC commented 10 months ago

I'm, once again, not convinced that the suggested coding and the long form description mean the same thing, but this is coded according to the DfE coding.

I think the long form description is slightly outdated due to amendments to both the collection and the rule. Worker team was something in the original proposed spec for the module but dropped before the guidance was issued. End date was in the original rule coding for 2023/24 but then dropped in the v1.2 revision.

SLornieCYC commented 10 months ago

now additionally closes #701

Is there a commit you've not pushed for this addition? The second issue is a tweak to be made in 2024/25 vs the initial 2023/24 implementation currently added in this PR.

SLornieCYC commented 8 months ago

now additionally closes #701

Is there a commit you've not pushed for this addition? The second issue is a tweak to be made in 2024/25 vs the initial 2023/24 implementation currently added in this PR.

Think this is the only bit left to resolve on this one.