data-to-insight / csc-validator-be-903

Python-side code for the Quality LAC Data Beta frontend
https://903.datatoinsight.org
MIT License
8 stars 4 forks source link

SWo3STG1 #741

Closed WillLP-code closed 8 months ago

WillLP-code commented 10 months ago

Closes #671

Fails children who have one of any of SW ID, SW DECOM, SW DEC, or SW REASON missing BUT allows children to pass if they only have SW DEC missing if they were looked after at 31 march (checked with the episode file having a null DEC and LA not being V3 or V4

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (15179c5) 95.27% compared to head (02a7571) 95.30%. Report is 47 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #741 +/- ## ========================================== + Coverage 95.27% 95.30% +0.02% ========================================== Files 313 314 +1 Lines 7717 7766 +49 ========================================== + Hits 7352 7401 +49 Misses 365 365 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SLornieCYC commented 10 months ago

This is one of those where I think you've overcomplicated the rule coding @WillLP-code. For the return LAs should only be providing SWEpisodes for children in care at 31 March anyway, so there isn't really a need to merge to Episodes and check that for this rule. (Although right now I can't actually see any rule that flags data submitted on children not in care at 31 March - but that's a DFE problem not ours!).

I think I'd be tempted to deviate slightly from the DFE coding and test there is content in all of the SWEpisode fields apart from DEC (which may be null). There are other rules that specifically test whether DEC is allowed to be blank for any particular episode (#747, #750, #705).