search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

feature/select rules #289

Closed tab1tha closed 1 year ago

tab1tha commented 1 year ago

The changes in this pull request allow the a sub-list of the existing rules to be run on the data, based on the user's preference. A selected_rules argument has been added to the cin_validate api function. It can accept a single string value or a list of strings where each string represents a rule code.

Other changes include further modularising of code to split up the large for loop that existed in the create_error_report function.

WillLP-code commented 1 year ago

@tab1tha At first glance this looks good, do you mind if I go and change some of the formatting of docstrings for consistency with the ones I wrote? Just things like having capitals at the start of sentences and having line breaks between function descriptions and parameters for readability?

tab1tha commented 1 year ago

Yep, looks good, but as per my comment I'd like to format some of the docstirngs a little. I'm happy to do it?

Yes. Sure @willLPD2I

If you can get it in by the end of today, that works. Else, I can merge this in so that the frontend part can start being built and then you open a new pull request when your changes are ready. I'll wait until close of business today.

tab1tha commented 1 year ago

Merging this in as agreed.