data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Bug: Rule 8869 - flags assessment factor as using 21 with others when the value is $A (unless there's another module not showing) #321

Closed WillLP-code closed 1 year ago

WillLP-code commented 1 year ago

Describe the bug Should flag where assessment factor 21 is used in conjunction with others (I'm going to look at the data again to check this one, my notes don't make sense.)

WillLP-code commented 1 year ago

This is wrongly flagging children who have assessment factors of 21 in one module, but have other assessment factors in a different one. It should only flag children who have 21 in the same assessments module as other factors. EG:

                <Assessments>
                    <AssessmentActualStartDate>XX-XX-XX</AssessmentActualStartDate>
                    <AssessmentAuthorisationDate>XX-XX-XX</AssessmentAuthorisationDate>
                    <FactorsIdentifiedAtAssessment>
                        <AssessmentFactors>21</AssessmentFactors>
                    </FactorsIdentifiedAtAssessment>
                </Assessments>
                <Assessments>
                    <AssessmentActualStartDate>XX-XX-XX</AssessmentActualStartDate>
                    <AssessmentAuthorisationDate>XX-XX-XX</AssessmentAuthorisationDate>
                    <FactorsIdentifiedAtAssessment>
                        <AssessmentFactors>XX</AssessmentFactors>
                        <AssessmentFactors>XX</AssessmentFactors>
                        <AssessmentFactors>XX</AssessmentFactors>
                    </FactorsIdentifiedAtAssessment>
                </Assessments>