search

data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

Test/general tests #331

Closed tab1tha closed 1 year ago

tab1tha commented 1 year ago

Check that the ruleset has the number of rules expected.

tab1tha commented 1 year ago

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

tab1tha commented 1 year ago

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

Actually, it is a test function. So it neither has parameters nor does it return anything. @willLPD2I With the test functions, can we include explanatory documentation only if needed ?

WillLP-code commented 1 year ago

Can you get this documented in sphinx format like the rest of the code then it looks good to go!

Sure

Actually, it is a test function. So it neither has parameters nor does it return anything. @willLPD2I With the test functions, can we include explanatory documentation only if needed ?

Sounds fair! If you could pop something really brief in the docs then?

tab1tha commented 1 year ago

When changes from the main branch are brought in, this test now fails because rules 8899Q and 8617 have been removed (https://github.com/data-to-insight/CIN-validator/issues/344). Hence the new total number of tests should be 105 instead of 107.