data-to-insight / csc-validator-be-cin

1 stars 1 forks source link

8620 bugfix #334

Closed WillLP-code closed 1 year ago

WillLP-code commented 1 year ago

closes #315

The previous calculation took the first day of the collection as the day after the previous years collection, but the test data, which has been accepted by the DFE as correct has lots of dates as the day of the last years collection end. As such, I've removed the - 1 year plus 1 day calculation and replaced it with just a minus 1 year calculation in make date, as this will solve the issue for any similar rules too.